Re: [PATCH] scsi: be2iscsi: Replace irq_poll with threaded IRQ handler.
From: kernel test robot <hidden>
Date: 2021-10-18 22:08:51
Also in:
llvm, oe-kbuild-all
Hi Sebastian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on jejb-scsi/for-next] [also build test WARNING on mkp-scsi/for-next v5.15-rc6 next-20211018] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sebastian-Andrzej-Siewior/scsi-be2iscsi-Replace-irq_poll-with-threaded-IRQ-handler/20211018-233450 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: x86_64-randconfig-r034-20211019 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d245f2e8597bfb52c34810a328d42b990e4af1a4) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/9f6ca42b58a498f5ab7a8b479087d14574d30618 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sebastian-Andrzej-Siewior/scsi-be2iscsi-Replace-irq_poll-with-threaded-IRQ-handler/20211018-233450 git checkout 9f6ca42b58a498f5ab7a8b479087d14574d30618 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All warnings (new ones prefixed by >>):
quoted
drivers/scsi/be2iscsi/be_main.c:707:8: warning: variable 'pbe_eq' is uninitialized when used here [-Wuninitialized]
eq = &pbe_eq->q;
^~~~~~
drivers/scsi/be2iscsi/be_main.c:699:26: note: initialize the variable 'pbe_eq' to silence this warning
struct be_eq_obj *pbe_eq;
^
= NULL
drivers/scsi/be2iscsi/be_main.c:733:24: warning: variable 'eq' set but not used [-Wunused-but-set-variable]
struct be_queue_info *eq;
^quoted
drivers/scsi/be2iscsi/be_main.c:5388:33: warning: variable 'i' is uninitialized when used here [-Wuninitialized]
pbe_eq = &phwi_context->be_eq[i];
^
drivers/scsi/be2iscsi/be_main.c:5373:16: note: initialize the variable 'i' to silence this warning
unsigned int i;
^
= 0
3 warnings generated.
vim +/pbe_eq +707 drivers/scsi/be2iscsi/be_main.c
695
696 static irqreturn_t be_iopoll(struct beiscsi_hba *phba)
697 {
698 unsigned int ret, io_events;
699 struct be_eq_obj *pbe_eq;
700 struct be_eq_entry *eqe = NULL;
701 struct be_queue_info *eq;
702
703 if (beiscsi_hba_in_error(phba))
704 return IRQ_NONE;
705
706 io_events = 0;
> 707 eq = &pbe_eq->q;
708 eqe = queue_tail_node(eq);
709 while (eqe->dw[offsetof(struct amap_eq_entry, valid) / 32] &
710 EQE_VALID_MASK) {
711 AMAP_SET_BITS(struct amap_eq_entry, valid, eqe, 0);
712 queue_tail_inc(eq);
713 eqe = queue_tail_node(eq);
714 io_events++;
715 }
716 hwi_ring_eq_db(phba, eq->id, 1, io_events, 0, 1);
717
718 ret = beiscsi_process_cq(pbe_eq);
719 pbe_eq->cq_count += ret;
720 beiscsi_log(phba, KERN_INFO,
721 BEISCSI_LOG_CONFIG | BEISCSI_LOG_IO,
722 "BM_%d : rearm pbe_eq->q.id =%d ret %d\n",
723 pbe_eq->q.id, ret);
724 if (!beiscsi_hba_in_error(phba))
725 hwi_ring_eq_db(phba, pbe_eq->q.id, 0, 0, 1, 1);
726
727 return IRQ_HANDLED;
728 }
729
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Attachments
- .config.gz [application/gzip] 39964 bytes