On 10/13/21 12:19 AM, Greg Kroah-Hartman wrote:

quoted

  static const struct attribute_group *ufshcd_driver_groups[] = {
  	&ufs_sysfs_unit_descriptor_group,
  	&ufs_sysfs_lun_attributes_group,

@@ -8183,6 +8219,7 @@ static struct scsi_host_template ufshcd_driver_template = {
  	.max_segment_size	= PRDT_DATA_BYTE_COUNT_MAX,
  	.max_host_blocked	= 1,
  	.track_queue_depth	= 1,
+	.shost_attrs		= ufshcd_shost_attrs,

Why can't this get added to the sdev_groups list?

The UFS error handler resets the host controller. There is one SCSI host 
per UFS host controller. Hence the choice to associate the sysfs 
attribute with the SCSI host.

There is one SCSI sdev per SCSI LUN. Although I'm not sure this can 
happen for UFS, it is possible that zero SCSI devices (sdevs) are 
associated with a SCSI host.

Bart.