Thread (3 messages) 3 messages, 2 authors, 2021-10-12

Re: [PATCH] target: allow setting dbroot as a module parameter

From: Maurizio Lombardi <hidden>
Date: 2021-10-12 08:56:54
Also in: target-devel

Hi Mike,

po 11. 10. 2021 v 18:50 odesílatel Mike Christie
[off-list ref] napsal:
On 9/27/21 2:38 PM, Maurizio Lombardi wrote:
quoted
The target driver prevents the users from changing
the database root directory if a target module like ib_srpt
has already been loaded during boot.
Why is that not allowed if we have a fabric driver loaded?

It looks like we don't start using the db_root until we have created
a device (alua and pr metadata)
Your solution would work perfectly for me but I still have a doubt:

CC: Lee Duncan

I think that changing db_root is not allowed if we have a fabric driver loaded
because the latter could have potentially used the core's dbroot
attribute to access the
directory's content.

See the description of the commit that introduced the configurable dbroot:
--------
commit a96e9783e05851d5f06da0ae7635aec55a228e3d
Author: Lee Duncan [off-list ref]
    target: make target db location configurable

    This commit adds the read-write attribute "dbroot",
    in the top-level CONFIGFS (core) target directory,
    normally /sys/kernel/config/target. This attribute
    defaults to "/var/target" but can be changed by
    writing a new pathname string to it. Changing this
    attribute is only allowed when no fabric drivers
    are loaded and the supplied value specifies an
    existing directory.

    Target modules that care about the target database
    root directory will be modified to use this
    attribute in a future commit.
--------

Maurizio
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help