Re: [PATCH 1/3] scsi: aic7xxx: fix building with -Werror (missing include)
From: James Bottomley <hidden>
Date: 2021-09-12 22:10:41
On Sun, 2021-09-12 at 23:32 +0200, Adam Borowski wrote:
quoted hunk ↗ jump to hunk
This is an userland helper tool to generate data rather than something compiled into the kernel, thus it wants regular POSIX functions. Signed-off-by: Adam Borowski <redacted> --- drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.cb/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c index 975fcfcc0d8f..2cd87ea86dfc 100644--- a/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c +++ b/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c@@ -45,6 +45,7 @@ #include <sys/types.h> #include "aicdb.h" +#include <ctype.h>
I'm really dubious about trying to get aicasm to compile with -Werror ... the driver is dying and we have prebuilt firmware headers in the tree so it's not like it's required. I'm also curious: if you compiled with -Werror how did you get around the missing function declarations induced by the -p mm in the bison command line? James