Thread (16 messages) 16 messages, 2 authors, 2021-09-22
STALE1768d LANDED

[PATCH 07/14] lpfc: Fix NVME I/O failover to non-optimized path

From: James Smart <hidden>
Date: 2021-09-10 23:32:38
Subsystem: emulex/broadcom lpfc fc/fcoe scsi driver, scsi subsystem, the rest · Maintainers: Justin Tee, Paul Ely, "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds

Currently, we hold off unregistering with NVME transport layer until
GID_FT or ADISC completes upon receipt of RSCN. In the ADISC discovery
routine, for nodes not found in the GID_FT response, the nodes are
unregistered from the scsi transport but not UNREG_RPI'd. Meaning
outstanding WQEs continue to be outstanding and were not failed back to
the OS. If an NVMe device, this mean there wasn't initial termination of
the I/O's so they could be issued on a different NVME path.

Fix by unregistering the RPI so that I/O is cancelled.

Fixes: 0614568361b0 ("scsi: lpfc: Delay unregistering from transport until GIDFT or ADISC completes")
Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <redacted>
---
 drivers/scsi/lpfc/lpfc_els.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index c6eae545aabf..40d166aeb466 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -6224,6 +6224,7 @@ lpfc_els_disc_adisc(struct lpfc_vport *vport)
 			 * from backend
 			 */
 			lpfc_nlp_unreg_node(vport, ndlp);
+			lpfc_unreg_rpi(vport, ndlp);
 			continue;
 		}
 
-- 
2.26.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help