Re: [PATCH V3 1/3] scsi: ufs: Fix error handler clear ua deadlock
From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-09-07 16:56:51
From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-09-07 16:56:51
On 9/7/21 8:43 AM, Adrian Hunter wrote:
No. Requests cannot make progress when ufshcd_state is UFSHCD_STATE_EH_SCHEDULED_FATAL, and only the error handler can change that, so if the error handler is waiting to enter the queue and blk_mq_freeze_queue() is waiting for outstanding requests, they will deadlock.
How about adding the above text as a comment above ufshcd_clear_ua_wluns() such that this information becomes available to those who have not followed this conversation? Thanks, Bart.