Re: [PATCH 36/51] scsi: Use scsi_target as argument for eh_target_reset_handler()
From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-08-19 18:37:24
On 8/17/21 2:14 AM, Hannes Reinecke wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/scsi/scsi_eh.rst b/Documentation/scsi/scsi_eh.rst index cf0649e0c3a9..e09c81a54702 100644 --- a/Documentation/scsi/scsi_eh.rst +++ b/Documentation/scsi/scsi_eh.rst@@ -215,6 +215,7 @@ considered to fail always. int (* eh_abort_handler)(struct scsi_cmnd *); int (* eh_device_reset_handler)(struct scsi_cmnd *); + int (* eh_target_reset_handler)(struct scsi_target *); int (* eh_bus_reset_handler)(struct Scsi_Host *, int); int (* eh_host_reset_handler)(struct Scsi_Host *);
Inconsistent indentation?
+ /** + * eh_target_reset_handler - issue SCSI target reset + * @starget: identifies SCSI target to be reset + * + * Returns SUCCESS if command aborted else FAILED + * + * Locks: None held + * + * Calling context: kernel thread + * + * Notes: Invoked from scsi_eh thread. No other commands will be + * queued on current host during eh. + * + * Optionally defined in: LLD + **/ + int eh_target_reset_handler(struct scsi_target * starget)
The above block comment does not follow the Linux kernel coding style ... Otherwise this patch looks good to me. Bart.