Thread (1 message) 1 message, 1 author, 2021-08-12

Re: [PATCH v2] scsi: qedi: Add support for fastpath doorvell recovery

From: "Martin K. Petersen" <martin.petersen@oracle.com>
Date: 2021-08-12 02:53:05

Guenter,
quoted
 	rval = qedi_ops->offload_conn(qedi->cdev, qedi_ep->handle, conn_info);
 	if (rval)
+		/* delete doorbell from doorbell recovery mechanism */
+		rval = qedi_ops->common->db_recovery_del(qedi->cdev,
+							 qedi_ep->p_doorbell,
+							 &qedi_ep->db_data);
+
 		QEDI_ERR(&qedi->dbg_ctx, "offload_conn returned %d, ep=%p\n",
 			 rval, qedi_ep);
Due to missing { } this will now always result in QEDI_ERR() execution
(and possibly a C compiler warning).
Fixed up. Thanks for spotting!

-- 
Martin K. Petersen	Oracle Linux Engineering
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help