Re: [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request

On 8/9/21 11:25 PM, Hannes Reinecke wrote:

On 8/10/21 1:03 AM, Bart Van Assche wrote:

quoted

Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
  drivers/scsi/advansys.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index f3377e2ef5fb..ffb391967573 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c

@@ -7423,7 +7423,7 @@ static int asc_build_req(struct asc_board 

*boardp, struct scsi_cmnd *scp,
       * Set the srb_tag to the command tag + 1, as
       * srb_tag '0' is used internally by the chip.
       */
-    srb_tag = scp->request->tag + 1;
+    srb_tag = scsi_cmd_to_rq(scp)->tag + 1;
      asc_scsi_q->q2.srb_tag = srb_tag;
      /*

@@ -7637,7 +7637,7 @@ static int

  adv_build_req(struct asc_board *boardp, struct scsi_cmnd *scp,
            adv_req_t **adv_reqpp)
  {
-    u32 srb_tag = scp->request->tag;
+    u32 srb_tag = scsi_cmd_to_rq(scp)->tag;
      adv_req_t *reqp;
      ADV_SCSI_REQ_Q *scsiqp;
      int ret;

Cf the previous patch; we really should introduce a helper to get the 
tag from a SCSI command.

Hi Hannes,

Is this something that you plan to work on or do you perhaps expect me 
to introduce such a helper?

Thanks,

Bart.