Re: [PATCH v4 12/52] NCR5380: Use scsi_cmd_to_rq() instead of scsi_cmnd.request

Hi Bart,

Am 07.08.2021 um 03:56 schrieb Bart Van Assche:

On 8/6/21 2:24 AM, Finn Thain wrote:

quoted

On Thu, 5 Aug 2021, Bart Van Assche wrote:

quoted

Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Acked-by: Finn Thain <fthain@linux-m68k.org>

Did you consider replacing rq_data_dir(cmd->request) with
cmd->sc_data_direction for this driver?

That's an interesting suggestion but I prefer to minimize the number of
changes I make in NCR5380 drivers since I do not have access to a setup
on which I can test any of these drivers.

The NCR5380 driver gets frequent testing on my Atari, so unless it's 
something integration specific, we ought to see any regressions there.

Cheers,

	Michael