Thread (30 messages) 30 messages, 2 authors, 2021-08-05

Re: [PATCH 07/14] qla2xxx: fix port type info

From: Himanshu Madhani <hidden>
Date: 2021-08-05 15:34:25

quoted hunk ↗ jump to hunk
On Aug 5, 2021, at 5:19 AM, Nilesh Javali [off-list ref] wrote:

From: Quinn Tran <redacted>

Over time, fcport->port_type became flag field. The flags within this field
were not defined properly. This caused external tools to read wrong info.

Signed-off-by: Quinn Tran <redacted>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
drivers/scsi/qla2xxx/qla_def.h | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index c081bf1c7578..60702d066ed9 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -2428,11 +2428,9 @@ struct mbx_24xx_entry {
 */
typedef enum {
	FCT_UNKNOWN,
-	FCT_RSCN,
-	FCT_SWITCH,
-	FCT_BROADCAST,
-	FCT_INITIATOR,
-	FCT_TARGET,
+	FCT_BROADCAST = 0x01,
+	FCT_INITIATOR = 0x02,
+	FCT_TARGET    = 0x04,
	FCT_NVME_INITIATOR = 0x10,
	FCT_NVME_TARGET = 0x20,
	FCT_NVME_DISCOVERY = 0x40,
-- 
2.19.0.rc0
Reviewed-by: Himanshu Madhani <redacted>

--
Himanshu Madhani	 Oracle Linux Engineering
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help