Re: [PATCH] scsi: sd: Do not exit sd_spinup_disk quietly
From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-08-17 03:14:16
Also in:
lkml
From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-08-17 03:14:16
Also in:
lkml
On 8/16/21 2:37 AM, Christian Löhle wrote:
The sd_spinup_disk function logs what is happening nicely. Unfortunately this output stops if the media was marked removed in the meantime. To prevent a puzzling output, add a print for this case, too. Signed-off-by: Christian Loehle <redacted> --- drivers/scsi/sd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index b8d55af763f9..7e556f5b57e0 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c@@ -2180,8 +2180,10 @@ sd_spinup_disk(struct scsi_disk *sdkp) * doesn't have any media in it, don't bother * with any more polling. */ - if (media_not_present(sdkp, &sshdr)) + if (media_not_present(sdkp, &sshdr)) { + sd_printk(KERN_NOTICE, sdkp, "Media removed, stopped polling\n"); return; + } if (the_result) sense_valid = scsi_sense_valid(&sshdr);
Reviewed-by: Bart Van Assche <bvanassche@acm.org>