RE: [PATCH] scsi: target: fix prot handling in WRITE SAME 32
From: Dmitriy Bogdanov <hidden>
Date: 2021-06-29 16:29:38
Also in:
target-devel
From: Dmitriy Bogdanov <hidden>
Date: 2021-06-29 16:29:38
Also in:
target-devel
Hi Martin,
quoted
WRITE SAME 32 command handling reads WRPROTECT at the wrong offset in 1st octet instead of 10th octet.
Instead of twiddling all these offsets I think it would be cleaner to turn the sbc_setup_write_same() flags[] into an 'unsigned char protect'. And then fix up sbc_check_prot() to take 'protect' as argument instead of the full CDB and indexing into that.
OK, I will prepare new version of the patch.
Another option would be passing the index but since cdb[0] is only used for a rare error message I'm not sure it's worth it.
BR, Dmitry