Re: [PATCH] mpt3sas: a shutdown fix
From: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Date: 2021-06-29 07:37:52
Tomas, During shutdown, we have to move the Controller state from Operational state to Ready state by issuing MUR (message unit reset). otherwise we may observe firmware faults when it sends some events or interrupts during reboot. Shall I post the new patch with the proper fix? Thanks, Sreekanth On Thu, Jun 24, 2021 at 8:38 PM Tomas Henzl [off-list ref] wrote:
quoted hunk ↗ jump to hunk
A driver doesn't have to to free allocated memory when in shutdown it is enough when it quiesces itself. This patch hardens the driver when additional commands are queued after .shutdown has been called. Signed-off-by: Tomas Henzl <redacted> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index dc2aaaf645d3..1885d13005cb 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c@@ -11293,7 +11293,7 @@ scsih_shutdown(struct pci_dev *pdev) _scsih_ir_shutdown(ioc); _scsih_nvme_shutdown(ioc); - mpt3sas_base_detach(ioc); + mpt3sas_base_stop_watchdog(ioc); } --2.31.1
Attachments
- smime.p7s [application/pkcs7-signature] 4218 bytes