Re: [PATCH RFC 4/4] ufs: Make host controller state change handling more systematic

On 6/21/21 1:55 AM, Avri Altman wrote:

quoted

+static bool ufshcd_set_state(struct ufs_hba *hba, enum ufshcd_state
new_state)
+{
+       lockdep_assert_held(hba->host->host_lock);
+
+       if (old_state != UFSHCD_STATE_ERROR || new_state ==
UFSHCD_STATE_ERROR)

old_state ?

Thanks for having taken a look. This function should look as follows:

static bool ufshcd_set_state(struct ufs_hba *hba, enum ufshcd_state new_state)
{
	lockdep_assert_held(hba->host->host_lock);

	if (hba->ufshcd_state != UFSHCD_STATE_ERROR ||
	    new_state == UFSHCD_STATE_ERROR) {
		hba->ufshcd_state = new_state;
		return true;
	}
	return false;
}