Re: [PATCH 1/2] virtio_scsi: do not overwrite SCSI status
From: Guenter Roeck <linux@roeck-us.net>
Date: 2021-06-19 20:06:03
On Thu, Jun 10, 2021 at 03:58:33PM +0200, Hannes Reinecke wrote:
When a sense code is present we should not override the scsi status;
the driver already sets it based on the response from the hypervisor.
Fixes: 464a00c9e0ad ("scsi: core: Kill DRIVER_SENSE")
Signed-off-by: Hannes Reinecke <hare@suse.de>As may be known by now, scsi-virtio support in linux-next is broken. The problem bisects to "scsi: core: Kill DRIVER_SENSE", and this patch fixes the problem. Tested-by: Guenter Roeck <linux@roeck-us.net> Guenter
quoted hunk ↗ jump to hunk
--- drivers/scsi/virtio_scsi.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index fd69a03d6137..43177a62916a 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c@@ -161,7 +161,6 @@ static void virtscsi_complete_cmd(struct virtio_scsi *vscsi, void *buf) min_t(u32, virtio32_to_cpu(vscsi->vdev, resp->sense_len), VIRTIO_SCSI_SENSE_SIZE)); - set_status_byte(sc, SAM_STAT_CHECK_CONDITION); } sc->scsi_done(sc);-- 2.26.2