Re: [PATCH 2/4] scsi: core: fix failure handling of scsi_add_host_with_dma

On 02/06/2021 14:30, Ming Lei wrote:

When scsi_add_host_with_dma() return failure, the caller will call
scsi_host_put(shost) to release everything allocated for this host
instance. So we can't free allocated stuff in scsi_add_host_with_dma(),
otherwise double free will be caused.

Strictly speaking, these host resources allocation should have been
moved to scsi_host_alloc(), but the allocation may need driver's
info which can be built between calling scsi_host_alloc() and
scsi_add_host(), so just keep the allocations in
scsi_add_host_with_dma().

Fixes the problem by relying on host device's release handler to
release everything.

Cc: Bart Van Assche<bvanassche@acm.org>
Cc: John Garry<redacted>
Cc: Hannes Reinecke<hare@suse.de>
Signed-off-by: Ming Lei<redacted>

Reviewed-by: John Garry <redacted>