Re: [PATCH 1/2] scsi: fc: Corrected RHBA attributes length
From: Himanshu Madhani <hidden>
Date: 2021-06-01 17:52:50
On 6/1/21 12:21 PM, Javed Hasan wrote:
quoted hunk ↗ jump to hunk
-As per document of FC-GS-5, attribute lengths of node_name and manufacturer should in range of "4 to 64 Bytes" only. Signed-off-by: Javed Hasan <jhasan@marvell.com> --- include/scsi/fc/fc_ms.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/include/scsi/fc/fc_ms.h b/include/scsi/fc/fc_ms.h index 9e273fed0a85..800d53dc9470 100644 --- a/include/scsi/fc/fc_ms.h +++ b/include/scsi/fc/fc_ms.h@@ -63,8 +63,8 @@ enum fc_fdmi_hba_attr_type { * HBA Attribute Length */ #define FC_FDMI_HBA_ATTR_NODENAME_LEN 8 -#define FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 80 -#define FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 80 +#define FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 64 +#define FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 64 #define FC_FDMI_HBA_ATTR_MODEL_LEN 256 #define FC_FDMI_HBA_ATTR_MODELDESCR_LEN 256 #define FC_FDMI_HBA_ATTR_HARDWAREVERSION_LEN 256
Looks good. Reviewed-by: Himanshu Madhani <redacted> -- Himanshu Madhani Oracle Linux Engineering