Thread (12 messages) 12 messages, 3 authors, 2021-06-16

Re: [PATCH v2 4/4] scsi: ufs: Use UPIU query trace in devman_upiu_cmd

From: Bean Huo <hidden>
Date: 2021-06-02 21:07:01
Also in: lkml

On Wed, 2021-06-02 at 10:29 +0800, Can Guo wrote:
quoted
       spin_lock_irqsave(hba->host->host_lock, flags);
@@ -6732,6 +6733,8 @@ static int
ufshcd_issue_devman_upiu_cmd(struct
ufs_hba *hba,
                       err = -EINVAL;
               }
       }
+     ufshcd_add_query_upiu_trace(hba, err ? UFS_QUERY_ERR : 
UFS_QUERY_COMP,
+                                 (struct utp_upiu_req *)lrbp-
quoted
ucd_rsp_ptr);
  out:
       blk_put_request(req);

What about ufshcd_exec_dev_cmd()?

Can,
thanks for your veiew.
yes, ufshcd_exec_dev_cmd() is only to send
UPIU command frame, and doesn't include CDB. It already uses
ufshcd_add_query_upiu_trace() to trace UPIU frame. 

Kind regards,
Bean
Thanks,

Can Guo.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help