Thread (3 messages) 3 messages, 3 authors, 2021-06-08

Re: [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port()

From: Himanshu Madhani <hidden>
Date: 2021-06-01 15:46:52
Also in: lkml


On 5/31/21 7:24 AM, Daniel Wagner wrote:
quoted hunk ↗ jump to hunk
Pass in fcport->vha to ql_log() in order to add the PCI address to the
log.

Currently NULL is passed in which gives this confusing log entry:
quoted
qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7
Signed-off-by: Daniel Wagner <redacted>
---
  drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index 0cacb667a88b..e119f8b24e33 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -671,7 +671,7 @@ void qla_nvme_unregister_remote_port(struct fc_port *fcport)
  	if (!IS_ENABLED(CONFIG_NVME_FC))
  		return;
  
-	ql_log(ql_log_warn, NULL, 0x2112,
+	ql_log(ql_log_warn, fcport->vha, 0x2112,
  	    "%s: unregister remoteport on %p %8phN\n",
  	    __func__, fcport, fcport->port_name);
  
Reviewed-by: Himanshu Madhani <redacted>

-- 
Himanshu Madhani                                Oracle Linux Engineering
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help