-----Original Message-----
From: Christoph Hellwig [mailto:hch@infradead.org]
Sent: Tuesday, May 18, 2021 1:09 PM
To: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: linux-scsi@vger.kernel.org; jejb@linux.ibm.com;
martin.petersen@oracle.com; steve.hagan@broadcom.com;
peter.rivera@broadcom.com; mpi3mr-linuxdrv.pdl@broadcom.com;
sathya.prakash@broadcom.com; bvanassche@acm.org; thenzl@redhat.com;
hare@suse.de; himanshu.madhani@oracle.com; hch@infradead.org
Subject: Re: [PATCH v5 01/24] mpi3mr: add mpi30 Rev-R headers and

Kconfig

quoted

+	help
+	This driver supports Broadcom's Unified MPI3 based Storage & RAID

Controllers.

Overly long line here.

Hi Christoph -

Will use new string " MPI3 based Storage & RAID Controllers Driver"

quoted

+#ifndef MPI30_API_H
+#define MPI30_API_H     1
+#include "mpi30_transport.h"
+#include "mpi30_image.h"
+#include "mpi30_init.h"
+#include "mpi30_ioc.h"
+#endif

Just including the four headers where needed directly would make more

sense

to me than this meta-header.

I will handle this in V6 submission.

quoted

+ *           Name: mpi30_image.h

We generally do not add comments like this.  It does not add any value

and

gets stale very quickly.

quoted

+ *  Creation Date: 04/02/2018
+ *        Version: 03.00.00

No need for this information either.  If you important from a specific

internal

version this is something that should go into the commit log.

I will handle this in V6 submission. I will remove all history from
Copyright section.

quoted

+struct _mpi3_comp_image_version {

Please drop the leading underscore from the various type names.

I will handle this in V6 submission.

Kashyap