Thread (55 messages) 55 messages, 4 authors, 2021-06-24

Re: [PATCH 07/18] scsi: revamp host device handling

From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-05-04 03:07:09

On 5/3/21 8:03 AM, Hannes Reinecke wrote:
+ *	Attach a single scsi_device to the Scsi_Host. The primary aim
+ *	for this device is to serve as a container from which valid
+ *	scsi commands can be allocated from. Each scsi command will carry
+ *	an unused/free command tag,
Shouldn't introducing this comment be deferred to the patch that
actually reserves a tag for internal commands (this does not mean that
I'm convinced that this is the right approach)?
+ *   which then can be used by the LLDD to
+ *	send internal or passthrough commands without having to find a
+ *	valid command tag internally.
Please change "valid SCSI commands" into "internal SCSI commands".

Thanks,

Bart.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help