Thread (4 messages) read the whole thread 4 messages, 2 authors, 2021-04-16
STALE1931d LANDED

Landed in mainline as 9d6f87c25ad5 on 2021-04-13.

[PATCH 2/2] qedf: use devlink to report errors and recovery

From: Javed Hasan <jhasan@marvell.com>
Date: 2021-03-31 16:51:11
Subsystem: qlogic ql41xxx fcoe driver, scsi subsystem, the rest · Maintainers: Saurav Kashyap, Javed Hasan, "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds

Use devlink_health_report to push error indications.
We implement this in qede via callback function to make it possible
to reuse the same for other drivers sitting on top of qed in future.
Also, remove forcible recovery trigger and put it as a normal devlink
callback in qed module.

This allows user to enable/disable it via

    devlink health set pci/xxxx:xx:xx.x reporter fw_fatal auto_recover false
---
 drivers/scsi/qedf/qedf_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 6b6c3fd97798..ad125b0ff1de 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -3859,8 +3859,9 @@ void qedf_schedule_hw_err_handler(void *dev, enum qed_hw_err_type err_type)
 		/* Prevent HW attentions from being reasserted */
 		qed_ops->common->attn_clr_enable(qedf->cdev, true);
 
-		if (qedf_enable_recovery)
-			qed_ops->common->recovery_process(qedf->cdev);
+		if (qedf_enable_recovery && qedf->devlink)
+			qed_ops->common->report_fatal_error(qedf->devlink,
+				err_type);
 
 		break;
 	default:
-- 
2.18.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help