Re: [PATCH v2 6/6] qla2xxx: Always check the return value of qla24xx_get_isp_stats()
From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-03-18 19:11:44
On 3/18/21 1:08 AM, Daniel Wagner wrote:
On Wed, Mar 17, 2021 at 08:28:40PM -0700, Bart Van Assche wrote:quoted
@@ -2873,7 +2875,9 @@ qla2x00_reset_host_stats(struct Scsi_Host *shost) } /* reset firmware statistics */ - qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0); + rval = qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0); + ql_log(ql_log_warn, vha, 0x70d9, + "Resetting ISP statistics failed: rval = %d\n", rval);Is there not an 'if' missing? if (rval) ql_log(...)
Right, I will add an if-statement. Thanks, Bart.