Re: [PATCH 4/7] qla2xxx: qla82xx_pinit_from_rom(): Initialize 'n' before using it
From: Himanshu Madhani <hidden>
Date: 2021-03-16 16:28:31
quoted hunk ↗ jump to hunk
On Mar 15, 2021, at 10:56 PM, Bart Van Assche [off-list ref] wrote: This patch suppresses the following sparse warning: qla_nx.c:1218: qla82xx_pinit_from_rom() error: uninitialized symbol 'n'. Cc: Quinn Tran <redacted> Cc: Mike Christie <michael.christie@oracle.com> Cc: Himanshu Madhani <redacted> Cc: Daniel Wagner <redacted> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/scsi/qla2xxx/qla_nx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index 0677295957bc..5683126e0cbc 100644 --- a/drivers/scsi/qla2xxx/qla_nx.c +++ b/drivers/scsi/qla2xxx/qla_nx.c@@ -1095,7 +1095,7 @@ qla82xx_pinit_from_rom(scsi_qla_host_t *vha)int i ; struct crb_addr_pair *buf; unsigned long off; - unsigned offset, n; + unsigned offset, n = 0; struct qla_hw_data *ha = vha->hw; struct crb_addr_pair {
Looks Good. Reviewed-by: Himanshu Madhani <redacted> -- Himanshu Madhani Oracle Linux Engineering