Thread (33 messages) 33 messages, 1 author, 2021-04-06
STALE1917d LANDED: 4 (0M)
Revisions (2)
  1. v4 [diff vs current]
  2. v5 current

[PATCH V5 28/31] smartpqi: update enclosure identifier in sysfs

From: Don Brace <don.brace@microchip.com>
Date: 2021-03-11 20:18:31
Subsystem: microsemi smart array smartpqi driver (smartpqi), scsi subsystem, the rest · Maintainers: Don Brace, "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds

From: Murthy Bhat <redacted>

Update enclosure identifier field corresponding to
physical devices in lsscsi/sysfs.

During device add, the scsi devtype is filled in during
slave_configure.

But when pqi_scsi_update_device runs (REGNEWD):
  * The f/w returns zero for the scsi devtype field,
    and valid devtype is overwritten by zero.
  * Due to this lsscsi output shows wrong values.

Reviewed-by: Scott Benesh <redacted>
Reviewed-by: Mike McGowen <redacted>
Reviewed-by: Scott Teel <redacted>
Reviewed-by: Kevin Barnett <redacted>
Signed-off-by: Murthy Bhat <redacted>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
 drivers/scsi/smartpqi/smartpqi_init.c |    1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 91616ddafd17..dbc0d3732d85 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -1840,7 +1840,6 @@ static void pqi_dev_info(struct pqi_ctrl_info *ctrl_info,
 static void pqi_scsi_update_device(struct pqi_scsi_dev *existing_device,
 	struct pqi_scsi_dev *new_device)
 {
-	existing_device->devtype = new_device->devtype;
 	existing_device->device_type = new_device->device_type;
 	existing_device->bus = new_device->bus;
 	if (new_device->target_lun_valid) {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help