Thread (55 messages) 55 messages, 5 authors, 2021-03-16

Re: [PATCH 00/23] target: code cleanup

From: michael.christie@oracle.com
Date: 2021-02-28 20:14:34
Also in: target-devel

On 2/27/21 11:56 PM, Chaitanya Kulkarni wrote:
Hi,

This removes unused macros, various memset, extra variable in the 
target/iblock for bio get and fixes type mismatch for the same.

The unused macros warning are found at compile time and they are
documented in each patch commit log. For memset removal, there are no
warnings.

First four patches are target_core_iblock.c cleanup. The next six
patches are removal of the unused macros followed by elevan patches to 
remove the memset for local array buffers. The last patch is for
removing the duplicate memset to initialize the buffer to 0xff.
 
I've tested this patch series with creating target bdev backend with
loop back transport, fio verification job seems to work fine.

Any feedback is welcome.

This is generated on today's linux-block for-next.
The patches look ok to me.

Reviewed-by: Mike Christie <michael.christie@oracle.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help