-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Monday, February 22, 2021 9:03 PM
To: Kashyap Desai <kashyap.desai@broadcom.com>; linux-
scsi@vger.kernel.org
Cc: jejb@linux.ibm.com; martin.petersen@oracle.com;
steve.hagan@broadcom.com; peter.rivera@broadcom.com; mpi3mr-
linuxdrv.pdl@broadcom.com; sathya.prakash@broadcom.com
Subject: Re: [PATCH 21/24] mpi3mr: add support of PM suspend and resume

On 12/22/20 11:11 AM, Kashyap Desai wrote:

quoted

Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: sathya.prakash@broadcom.com
---
 drivers/scsi/mpi3mr/mpi3mr_os.c | 85
+++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c

b/drivers/scsi/mpi3mr/mpi3mr_os.c index 1708aca1a5cd..ac47eed74705
100644

--- a/drivers/scsi/mpi3mr/mpi3mr_os.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_os.c

...

quoted

+/**
+ * mpi3mr_resume - PCI power management resume callback
+ * @pdev: PCI device instance
+ *
+ * Restore the power state to D0 and reinitialize the controller
+ * and resume I/O operations to the target devices
+ *
+ * Return: 0 on success, non-zero on failure  */ static int
+mpi3mr_resume(struct pci_dev *pdev) {
+	struct Scsi_Host *shost = pci_get_drvdata(pdev);
+	struct mpi3mr_ioc *mrioc;
+	pci_power_t device_state = pdev->current_state;
+	int r;
+
+	mrioc = shost_priv(shost);
+
+	ioc_info(mrioc, "pdev=0x%p, slot=%s, previous operating state

[D%d]\n",

quoted

+	    pdev, pci_name(pdev), device_state);
+	pci_set_power_state(pdev, PCI_D0);
+	pci_enable_wake(pdev, PCI_D0, 0);
+	pci_restore_state(pdev);
+	mrioc->pdev = pdev;
+	mrioc->cpu_count = num_online_cpus();
+	r = mpi3mr_setup_resources(mrioc);
+	if (r) {
+		ioc_info(mrioc, "%s: Setup resoruces failed[%d]\n",

A typo 					here ^

Noted. I will fix it in V2. I will scan all the patch for such things one
more time.

Kashyap

quoted

+		    __func__, r);
+		return r;
+	}