On Feb 17, 2021, at 8:12 AM, Gulam Mohamed [off-list ref] wrote:

Hi Michael,

       Regarding " Also there might be the case where a tool sets a value then forces a relogin and the new value would get used for some drivers." in your below mail, I was trying to understand this. Can you please give me an example? It will help me to understand clearly.

Open-iscsi stores the config values in a bunch of files on the system's FS. But other implementations could use sysfs like a tmp local FS. For this, if you wanted to use a new max burst value then you would do set_param, and during login your tools could read sysfs and pick up that value.

We used to do something like this for boot. We would read the values from a mix of cmdline, ibft, etc, then create a session. When iscsid started up again on the real root it could read the values used from sysfs. In this example, we used sysfs as a tmp place to store our info, but people would want to extend this and instead of using that “bunch of files”, just use sysfs/set_param to get/store the iscsi info for the life of the boot.

Regards,
Gulam Mohamed.

-----Original Message-----
From: Michael Christie <michael.christie@oracle.com> 
Sent: Wednesday, February 3, 2021 7:47 AM
To: Gulam Mohamed <redacted>; lduncan@suse.com; cleech@redhat.com; Martin Petersen <martin.petersen@oracle.com>; linux-scsi@vger.kernel.org
Subject: Re: [PATCH V3] iscsi: Do Not set param when sock is NULL

On 1/28/21 12:17 AM, Gulam Mohamed wrote:

quoted

Description
===========
1. This Kernel panic could be due to a timing issue when there is a race
  between the sync thread and the initiator was processing of a login 
r

Hey,

Sorry. When I had said that we want to limit the width, I didn't mean that it should split words like above.

quoted

	default:
+		if (conn->state != ISCSI_CONN_BOUND)
+			return -ENOTCONN;

How about making this a check for BOUND or UP? Some of the settings, like the TMF related ones, can be set after the conn is connected. open-iscsi doesn't support it, but maybe other tools do. Also there might be the case where a tool sets a value then forces a relogin and the new value would get used for some drivers.