[PATCH 00/12 V2] target: fix cmd plugging and completion · Mike Christie <michael.christie@oracle.com> · 2021-02-09
[PATCH 01/13] target: move t_task_cdb initialization · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 01/13] target: move t_task_cdb initialization · Christoph Hellwig <hch@infradead.org> · 2021-02-10
[PATCH 02/13] target: split target_submit_cmd_map_sgls · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 02/13] target: split target_submit_cmd_map_sgls · kernel test robot <hidden> · 2021-02-09
Re: [PATCH 02/13] target: split target_submit_cmd_map_sgls · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 02/13] target: split target_submit_cmd_map_sgls · Christoph Hellwig <hch@infradead.org> · 2021-02-10
[PATCH 04/13] vhost scsi: use lio wq cmd submission helper · Mike Christie <michael.christie@oracle.com> · 2021-02-09
[PATCH 03/13] target: add workqueue based cmd submission · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 03/13] target: add workqueue based cmd submission · Bodo Stroesser <bostroesser@gmail.com> · 2021-02-09
Re: [PATCH 03/13] target: add workqueue based cmd submission · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 03/13] target: add workqueue based cmd submission · Mike Christie <michael.christie@oracle.com> · 2021-02-10
[PATCH 05/13] tcm loop: use blk cmd allocator for se_cmds · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 05/13] tcm loop: use blk cmd allocator for se_cmds · Christoph Hellwig <hch@infradead.org> · 2021-02-10
[PATCH 07/13] target: cleanup cmd flag bits · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 07/13] target: cleanup cmd flag bits · Christoph Hellwig <hch@infradead.org> · 2021-02-10
[PATCH 09/13] target iblock: add backend plug/unplug callouts · Mike Christie <michael.christie@oracle.com> · 2021-02-09
[PATCH 08/13] target: fix backend plugging · Mike Christie <michael.christie@oracle.com> · 2021-02-09
[PATCH 10/13] target_core_user: add backend plug/unplug callouts · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 10/13] target_core_user: add backend plug/unplug callouts · Bodo Stroesser <bostroesser@gmail.com> · 2021-02-09
Re: [PATCH 10/13] target_core_user: add backend plug/unplug callouts · Mike Christie <michael.christie@oracle.com> · 2021-02-09
[PATCH 06/13] tcm loop: use lio wq cmd submission helper · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 06/13] tcm loop: use lio wq cmd submission helper · Bodo Stroesser <bostroesser@gmail.com> · 2021-02-09
Re: [PATCH 06/13] tcm loop: use lio wq cmd submission helper · Mike Christie <michael.christie@oracle.com> · 2021-02-10
Re: [PATCH 06/13] tcm loop: use lio wq cmd submission helper · kernel test robot <hidden> · 2021-02-09
[PATCH 11/13] target: replace work per cmd in completion path · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 11/13] target: replace work per cmd in completion path · Bodo Stroesser <bostroesser@gmail.com> · 2021-02-09
Re: [PATCH 11/13] target: replace work per cmd in completion path · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 11/13] target: replace work per cmd in completion path · Christoph Hellwig <hch@infradead.org> · 2021-02-10
Re: [PATCH 11/13] target: replace work per cmd in completion path · Mike Christie <michael.christie@oracle.com> · 2021-02-10
[PATCH 13/13] target: flush submission work during TMR processing · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 13/13] target: flush submission work during TMR processing · Laurence Oberman <hidden> · 2021-02-09
Re: [PATCH 13/13] target: flush submission work during TMR processing · Laurence Oberman <hidden> · 2021-02-10
Re: [PATCH 13/13] target: flush submission work during TMR processing · Bodo Stroesser <bostroesser@gmail.com> · 2021-02-09
Re: [PATCH 13/13] target: flush submission work during TMR processing · Mike Christie <michael.christie@oracle.com> · 2021-02-09
[PATCH 12/13] target, vhost-scsi: don't switch cpus on completion · Mike Christie <michael.christie@oracle.com> · 2021-02-09
Re: [PATCH 12/13] target, vhost-scsi: don't switch cpus on completion · Christoph Hellwig <hch@infradead.org> · 2021-02-10
Re: [PATCH 12/13] target, vhost-scsi: don't switch cpus on completion · Mike Christie <michael.christie@oracle.com> · 2021-02-10
Re: [PATCH 12/13] target, vhost-scsi: don't switch cpus on completion · Mike Christie <michael.christie@oracle.com> · 2021-02-10

Re: [PATCH 06/13] tcm loop: use lio wq cmd submission helper

From: Mike Christie <michael.christie@oracle.com>
Date: 2021-02-10 00:15:55
Also in: target-devel

On 2/9/21 9:59 AM, Bodo Stroesser wrote:

On 09.02.21 13:38, Mike Christie wrote:

quoted

@@ -179,6 +184,11 @@ static void tcm_loop_submission_work(struct work_struct *work)

  static int tcm_loop_queuecommand(struct Scsi_Host *sh, struct scsi_cmnd *sc)
  {
      struct tcm_loop_cmd *tl_cmd = scsi_cmd_priv(sc);
+    struct tcm_loop_hba *tl_hba;
+    struct tcm_loop_tpg *tl_tpg;
+
+    tl_hba = *(struct tcm_loop_hba **)shost_priv(sc->device->host);
+    tl_tpg = &tl_hba->tl_hba_tpgs[sc->device->id];
        pr_debug("%s() %d:%d:%d:%llu got CDB: 0x%02x scsi_buf_len: %u\n",
           __func__, sc->device->host->host_no, sc->device->id,

AFAICS these new lines are not needed. Or am I missing something?

You're right. I'll fix it.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help