Re: [PATCH 08/11] target iblock: add backend plug/unplug callouts

On 2/6/21 5:06 PM, Chaitanya Kulkarni wrote:

On 2/4/21 03:40, Mike Christie wrote:

quoted

 
+	ib_dev->ibd_plug = kcalloc(nr_cpu_ids, sizeof(*ib_dev->ibd_plug),
+				   GFP_KERNEL);

I'd actually prefer struct xxx in sizeof, but maybe that is just my
preference.
Not sure what is the standard practice in target code.

The above code is easier to verify than the suggested alternative. With
the alternative one has to look up the definition of ibd_plug to verify
correctness of the code. The above code can be verified without having
to look up the definition of the ibd_plug member.

Bart.