quoted

quoted

quoted

quoted

+       err = ufshpb_fill_ppn_from_page(hpb, srgn->mctx, srgn_offset, 1,

&ppn);

quoted

quoted

+       spin_unlock_irqrestore(&hpb->rgn_state_lock, flags);
+       if (unlikely(err < 0)) {
+               /*
+                * In this case, the region state is active,
+                * but the ppn table is not allocated.
+                * Make sure that ppn table must be allocated on
+                * active state.
+                */
+               WARN_ON(true);
+               dev_err(hba->dev, "get ppn failed. err %d\n", err);

Maybe just pr_warn instead of risking crashing the machine over that?

Why it crashing the machine? WARN_ON will just print kernel message.

I think that it can be configured, but I am not sure.

I think it can be configured via the parameter panic_on_warn

OK, I will change WARN_ON to dev_err for print message.

Thanks,
Daejun