Thread (63 messages) 63 messages, 4 authors, 2021-02-25
STALE1971d

[PATCH for-next 26/32] scsi: qlogicfas408: Replace spin_lock_irqsave with spin_lock in hard IRQ

From: Xiaofei Tan <hidden>
Date: 2021-02-07 11:45:46
Also in: lkml
Subsystem: scsi subsystem, the rest · Maintainers: "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds

It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <redacted>
---
 drivers/scsi/qlogicfas408.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qlogicfas408.c b/drivers/scsi/qlogicfas408.c
index 136681a..2a70902 100644
--- a/drivers/scsi/qlogicfas408.c
+++ b/drivers/scsi/qlogicfas408.c
@@ -426,12 +426,11 @@ static void ql_ihandl(void *dev_id)
 
 irqreturn_t qlogicfas408_ihandl(int irq, void *dev_id)
 {
-	unsigned long flags;
 	struct Scsi_Host *host = dev_id;
 
-	spin_lock_irqsave(host->host_lock, flags);
+	spin_lock(host->host_lock);
 	ql_ihandl(dev_id);
-	spin_unlock_irqrestore(host->host_lock, flags);
+	spin_unlock(host->host_lock);
 	return IRQ_HANDLED;
 }
 
-- 
2.8.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help