Thread (31 messages) 31 messages, 8 authors, 2018-06-04

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

From: Christoph Hellwig <hch@infradead.org>
Date: 2018-03-21 18:50:13
Also in: linux-rt-users, lkml, target-devel

On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote:
 	assert_spin_locked(&cmd->t_state_lock);
-	WARN_ON_ONCE(!irqs_disabled());
+	WARN_ON_ONCE_NONRT(!irqs_disabled());
I can't find where WARN_ON_ONCE_NONRT is defined.

That being said I think we can just kill these asserts.  If we have irqs
disabled spin_unlock_irq a few lines below should already warn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help