Thread (4 messages) 4 messages, 3 authors, 2017-05-21

Re: [PATCH] Use ctlr directly in rdac_failover_get()

From: Bart Van Assche <hidden>
Date: 2017-05-19 22:23:39
Also in: lkml

On Fri, 2017-05-19 at 14:06 +0200, Artem Savkov wrote:
rdac_failover_get references struct rdac_controller as
ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being
inefficient this also introduces a null-pointer dereference as
send_mode_select() sets ctlr->ms_sdev to NULL before calling
rdac_failover_get():

[ ... ]
Signed-off-by: Artem Savkov <redacted>
Hello Artem,

Although this patch looks fine to me, please consider adding the "Fixes:" and
"Cc: [off-list ref]" tags.

Bart.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help