Re: [RFC 19/34] iscsi-target: clear tx_thread_active
From: Sagi Grimberg <hidden>
Date: 2016-02-15 17:07:46
On 14/02/2016 19:42, Varun Prakash wrote:
quoted hunk ↗ jump to hunk
clear tx_thread_active for ISCSI_TCP_CXGB4 transport in logout_post_handler functions. Signed-off-by: Varun Prakash <varun@chelsio.com> --- drivers/target/iscsi/iscsi_target.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 858f6e4..3dd7ba2 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c@@ -4579,7 +4579,8 @@ static void iscsit_logout_post_handler_closesession( * always sleep waiting for RX/TX thread shutdown to complete * within iscsit_close_connection(). */ - if (conn->conn_transport->transport_type == ISCSI_TCP) + if ((conn->conn_transport->transport_type == ISCSI_TCP) || + (conn->conn_transport->transport_type == ISCSI_TCP_CXGB4)) sleep = cmpxchg(&conn->tx_thread_active, true, false);
Again, this is not the right way to make progress...