Thread (2 messages) 2 messages, 2 authors, 2015-01-29

Re: [PATCH v2 0/6] scsi: Some seq_file cleanups/optimizations

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2015-01-29 14:22:56
Also in: linux-fsdevel, lkml

On Thu, 29 Jan 2015 10:16:16 +0100
Rasmus Villemoes [off-list ref] wrote:
Steven, you've been doing some cleanup in this area, among other things
trying to make all the seq_* functions return void. Could you fill me in
on the status of that?
Yes, the entire seq_*() operations are ambiguous in how they handle
filling the buffers. Don't worry about side effects of using one seq
operation over another (I highly doubt anyone will notice).

I had to stop doing the cleanups to work on other things, but I have
patches to make all seq operations perform the same (and also use the
new seq_buf infrastructure).

And, please ignore any return value from the seq operations. If you
want to know if the buffer is full use seq_has_overflowed() to find out.

I'll try to continue this clean up as a side project.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help