Re: [PATCH 1/3] Documentation: Add APM X-Gene SoC 6.0Gbps SATA PHY driver binding documentation
From: Arnd Bergmann <hidden>
Date: 2013-11-15 12:35:09
Also in:
linux-arm-kernel, linux-devicetree, linux-ide
On Thursday 14 November 2013, Loc Ho wrote:
+- id : PHY ID (0 = first, 1 = second, 2 = third) +- #phy-cells : Shall be 0
Hmm, it seems like this would make more sense if you have #phy-cells=<1> and have the PHY ID in user node as the argument.
+- CTLE0 : PHY override parameters for channel 0 register REG1 + field CTLE_EQ. First value for Gen1, second value + for Gen2, and third value for Gen3. Default is 0x2. +- CTLE1 : PHY override parameters for channel 1 register REG1 + field CTLE_EQ. First value for Gen1, second value + for Gen2, and third value for Gen3. Default is 0x2. +- PQ0 : PHY override parameters for channel 0 register REG125 + field PQ_REG. First value for Gen1, second value + for Gen2, and third value for Gen3. Default is 0xA. +- PQ1 : PHY override parameters for channel 1 register REG125 + field PQ_REG. First value for Gen1, second value + for Gen2, and third value for Gen3. Default is 0xA.
As mentioned before, I don't think putting register-level information into the binding is the right approach here. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html