On Wed, 2012-10-24 at 01:45 -0500, Mike Christie wrote:

On 10/19/2012 06:15 PM, John Soni Jose wrote:

quoted

@@ -763,26 +750,14 @@ static int beiscsi_get_port_speed(struct Scsi_Host *shost)
 			    "BS_%d : Getting Port Speed Failed\n");
 
 		 return -EBUSY;
-	 } else
-		wait_event_interruptible(phba->ctrl.mcc_wait[tag],
-				phba->ctrl.mcc_numtag[tag]);
-
-	wrb_num = (phba->ctrl.mcc_numtag[tag] & 0x00FF0000) >> 16;
-	extd_status = (phba->ctrl.mcc_numtag[tag] & 0x0000FF00) >> 8;
-	status = phba->ctrl.mcc_numtag[tag] & 0x000000FF;
-
-	if (status || extd_status) {
+	 }
+	rc = beiscsi_mccq_compl(phba, tag, &wrb, NULL);
+	if (rc) {
 		beiscsi_log(phba, KERN_ERR,

There was some small whitespace issues in this patch. Maybe James will
fix it up when it is merged. I do not know why checkpatch.pl and git did
not warn about them.

I fixed it up.  I cc'd the checkpatch.pl maintainer.  No idea why it
failed to spot the extra space at line 465 in the patch.

James