Re: [patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

Bart Van Assche [off-list ref] writes:

On 11/09/12 20:18, Jeff Moyer wrote:

quoted

-	cmd = kmem_cache_zalloc(pool->cmd_slab, gfp_mask | pool->gfp_mask);
+	cmd = kmem_cache_alloc_node(pool->cmd_slab,
+				    gfp_mask | pool->gfp_mask | __GFP_ZERO,
+				    node);

Hello Jeff,

Is it necessary to add __GFP_ZERO here ? And if so, why ?

Hi, Bart,

The code used to do zeroing, so I just kept that aspect the same.  There
is no kmem_cache_zalloc_node, and it didn't seem worth adding one.

Cheers,
Jeff