Thread (3 messages) 3 messages, 3 authors, 2012-09-28

Re: [SCSI PATCH] sd: max-retries becomes configurable

From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: 2012-09-27 04:45:30
Also in: lkml

Possibly related (same subject, not in this thread)

On Wed, 2012-09-26 at 22:20 -0400, Martin K. Petersen wrote:
quoted
quoted
quoted
quoted
quoted
"James" == James Bottomley [off-list ref] writes:
James> On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote:
quoted
quoted
drivers/scsi/sd.c | 4 ++++ drivers/scsi/sd.h | 2 +- 2 files changed,
5 insertions(+), 1 deletion(-)
James> I'm not opposed in principle to doing this (except that it should
James> be a sysfs parameter like all our other controls),

Now that we're in that department. I never got any feedback on the
following patch.

Hannes told me in person that he felt the eh_timeout belonged in
scsi_device and not in the request queue. Whereas I favored making it a
block layer tunable despite currently only being used by SCSI. Any
opinions?
request_queue makes more sense to me because there was once a plan to
move all our timeout processing to block.  I think it got stalled
somewhere, but this would act as a reminder.

James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help