On Thu, Mar 29, 2012 at 02:03:55PM +0200, Jens Axboe wrote:

On 03/29/2012 07:36 AM, Ren Mingxin wrote:

quoted

 On 03/28/2012 06:58 PM, Michael S. Tsirkin wrote:

quoted

On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote:

quoted

  Hi,

The current virtblk's naming algorithm just supports 26^3
disks. If there are mass of virtblks(exceeding 26^3), there
will be disks with the same name.

According to "sd_format_disk_name()", I add function
"virtblk_name_format()" for virtblk to support mass of
disks.

Signed-off-by: Ren Mingxin<redacted>

Nod. This is basically what 3e1a7ff8a0a7b948f2684930166954f9e8e776fe
did. Except, maybe we should move this function into block core
instead of duplicating it? Where would be a good place to put it?

Yes, this was also what I thought.

How about placing the "sd_format_disk_name()"
as "disk_name_format()" into "block/genhd.c"
("include/linux/genhd.h")?

Yes, that sounds like the appropriate solution (and name, and where to
put it).

OK, once this is posted I'll get your ack and
queue for 3.4 with other virtio fixups.

-- 
Jens Axboe