Re: [PATCH 08/18] bnx2fc: Handle NETDEV_UNREGISTER for vlan devices
From: Bhanu Prakash Gollapudi <hidden>
Date: 2011-08-24 20:41:02
On 8/18/2011 4:52 PM, Bhanu Gollapudi wrote:
On Thu, 2011-08-04 at 11:47 -0700, Bhanu Prakash Gollapudi wrote:quoted
Since the driver holds the reference for vlan netdev, the reference has to be released by the driver when the vlan device is removed. Driver handles this in NETDEV_UNREGISTER event. Signed-off-by: Bhanu Prakash Gollapudi<redacted>As per Mike Christie's comments, we need not call __bnx2fc_destroy() with schedule parameter, because we are already in the right context with indicate_netevent being called with rtnl_lock(). Re-spinning this patch alone with 'schedule' parameter removed from __bnx2fc_destroy().
James, I realize that the modified patch has not been picked up by you. I will submit a follow-on patch with specific changes shortly. Thanks.
quoted hunk ↗ jump to hunk
------------------------ Since the driver holds the reference for vlan netdev, the reference has to be released by the driver when the vlan device is removed. Driver handles this in NETDEV_UNREGISTER event. Signed-off-by: Bhanu Prakash Gollapudi<redacted> --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 87 ++++++++++++++++++++++--------------- 1 files changed, 52 insertions(+), 35 deletions(-)diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 673c97c..9a7077b 100644