On 8/26/2011 12:26 AM, Randy Dunlap wrote:

quoted

On Wed, August 24, 2011 11:35 pm, Stephen Rothwell wrote:

quoted

Hi all,

The powerpc allyesconfig build still fails today.

CONFIG_FCOE is not enabled:

drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function 'bnx2fc_net_config':
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:765: error: 'NETDEV_FCOE_WWNN'
undeclared (first use in this function)
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:771: error: 'NETDEV_FCOE_WWPN'
undeclared (first use in this function)


Maybe this driver should select FCOE?

bnx2fc does not depend on FCOE. Instead both fcoe and bnx2fc drivers
depend on LIBFCOE.  So, I'll modify to access
NETDEV_FCOE_WWNN/NETDEV_FCOE_WWPN when CONFIG_LIBFCOE  is enabled.

Yes, both these two flags and ndo_fcoe_get_wwn() should be wrapped by
CONFIG_LIBFCOE || CONFIG_LIBFCOE_MODULE as bnx2fc is also using the get_wwn
hook I believe. Historically on fcoe module was using them.

Patch will be submitted soon.

Thanks,
yi

Thanks,
Bhanu

quoted

~Randy

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi"

in

quoted

the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html