Re: [build failure] Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window

On Mon, 2011-03-21 at 13:21 +0100, Ingo Molnar wrote:

* James Bottomley [off-list ref] wrote:

quoted

This represents the usual round of driver updates (fcoe, lpfc,

qla2xxx, > zfcp, bnx2i, mpt2sas, megaraid_sas, iscsi, cxgbi and hpsa)
plus one new > driver (bnx2fc) and as a bonus we move libsas from the
old libata eh to > the new one paving the way for junking the old one
(once we can get ipr > converted).

The new bnx2fc driver does not build with module support disabled:

 drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815:17: error: dereferencing
pointer to incomplete type  drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815:28:
error: ‘MODULE_STATE_LIVE’ undeclared (first use in this function)
  drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1878:17: error: dereferencing
pointer to incomplete type  drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1878:28:
error: ‘MODULE_STATE_LIVE’ undeclared (first use in this function)

and this build breakage has been reported to you two weeks ago:

 http://lkml.org/lkml/2011/3/2/468

The actual fix is here:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=e81460b20107ae83a7541d12b14114ea731a86fc

it just took time to secure agreement on this.  The ultimate fixes to
FCoE will be in the next merge window.

James