Re: [PATCH] osst: wrong index used in inner loop
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: 2011-03-21 01:03:57
Also in:
lkml
On Sat, 19 Mar 2011 20:53:53 +0100 roel [off-list ref] wrote:
Index i was already used in the outer loop. Signed-off-by: Roel Kluin <redacted> --- drivers/scsi/osst.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) I'm not sure if this is the right fix, maybe a break or return is missing?
What are you trying to fix with this patch?
quoted hunk ↗ jump to hunk
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index 521e218..d6d6d89 100644 --- a/drivers/scsi/osst.c +++ b/drivers/scsi/osst.c@@ -4702,8 +4702,9 @@ static int __os_scsi_tape_open(struct inode * inode, struct file * filp) STp->partition = STp->new_partition = 0; if (STp->can_partitions) STp->nbr_partitions = 1; /* This guess will be updated later if necessary */ - for (i=0; i < ST_NBR_PARTITIONS; i++) { - STps = &(STp->ps[i]); + int j; + for (j=0; j < ST_NBR_PARTITIONS; j++) { + STps = &(STp->ps[j]); STps->rw = ST_IDLE; STps->eof = ST_NOEOF; STps->at_sm = 0; --To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html