Thread (52 messages) 52 messages, 10 authors, 2011-05-05

Re: [RFC] block integrity: Fix write after checksum calculation problem

From: Joel Becker <jlbec@evilplan.org>
Date: 2011-02-23 21:42:27
Also in: linux-fsdevel, lkml

Possibly related (same subject, not in this thread)

On Wed, Feb 23, 2011 at 03:35:11PM -0500, Chris Mason wrote:
quoted
    ocfs2 handles stable metadata for its checksums when feeding
things to the journal.  If we're doing pagecache-based I/O, is the
pagecache going to help here for data?
Data is much easier than metadata.  All you really need is to wait on
writeback in file_write, wait on writeback in page_mkwrite, and make
sure you don't free blocks back to the allocator that are actively under
IO.

I expect the hard part to be jbd and metadata in ext34.
	Yeah, catching use-without-access is not trivial.  I keep
thinking we've found them all, and then another bug crops up ;-)  At
least our checksums catch it.

Joel

-- 

"The doctrine of human equality reposes on this: that there is no
 man really clever who has not found that he is stupid."
	- Gilbert K. Chesterson

			http://www.jlbec.org/
			jlbec@evilplan.org
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help