Re: Request for review of Linux iSCSI driver version 4.0.0.1
From: N.C.Krishna Murthy <hidden>
Date: 2003-12-04 12:32:29
Hi, Please find my replies/quieries interspersed in your reply. On Monday 01 Dec 2003 8:52 pm, James Bottomley wrote:
On Mon, 2003-12-01 at 06:10, Krishna Murthy wrote:quoted
Hi, We could use probing code from mid layer provided scsi_scan_host_selected is exported. iscsi driver does probe for devices at two places a)Once after session establishment. b)Whenever an iSCSI async message indicates a change in "REPORTED LUNS DATA". (addition/deletion of luns on the target)This sounds like an async event which could be handled by the hotplug system. Would there be a problem with simply transmitting this to a user level utility and having it trigger the rescan through the exported sysfs interfaces?
Having user level utility trigger the rescan thru sysfs interfaces will call scsi_scan() which will inturn call scsi_scan_host_selected(). Instead wouldn't it be preferable to call scsi_scan_host_selected() from the iSCSI driver itself?
We could do with a generic infrastructure within SCSI for generating these events, anyway, if you want to go that route...
I am not much familiar with SCSI hotplug. If the generic infrastructure which you mentioned does not exist now and in case there is a plan to do one such thing is there any framework for that? Wouldn't that require a kernel API which is capable of both "adding new luns" and "deleting luns which no longer exist"? Please let us know Thanx N.C.Krishna Murthy