Re: [PATCH 2/5] dax: simplify dax_synchronous and set_dax_synchronous
From: Dan Williams <hidden>
Date: 2021-12-12 14:23:54
Also in:
dm-devel, linux-fsdevel, nvdimm, virtualization
On Wed, Dec 8, 2021 at 10:38 PM Christoph Hellwig [off-list ref] wrote:
Remove the pointless wrappers. Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good, not sure why those ever existed. Reviewed-by: Dan Williams <redacted>
quoted hunk ↗ jump to hunk
--- drivers/dax/super.c | 8 ++++---- include/linux/dax.h | 12 ++---------- 2 files changed, 6 insertions(+), 14 deletions(-)diff --git a/drivers/dax/super.c b/drivers/dax/super.c index e7152a6c4cc40..e18155f43a635 100644 --- a/drivers/dax/super.c +++ b/drivers/dax/super.c@@ -208,17 +208,17 @@ bool dax_write_cache_enabled(struct dax_device *dax_dev) } EXPORT_SYMBOL_GPL(dax_write_cache_enabled); -bool __dax_synchronous(struct dax_device *dax_dev) +bool dax_synchronous(struct dax_device *dax_dev) { return test_bit(DAXDEV_SYNC, &dax_dev->flags); } -EXPORT_SYMBOL_GPL(__dax_synchronous); +EXPORT_SYMBOL_GPL(dax_synchronous); -void __set_dax_synchronous(struct dax_device *dax_dev) +void set_dax_synchronous(struct dax_device *dax_dev) { set_bit(DAXDEV_SYNC, &dax_dev->flags); } -EXPORT_SYMBOL_GPL(__set_dax_synchronous); +EXPORT_SYMBOL_GPL(set_dax_synchronous); bool dax_alive(struct dax_device *dax_dev) {diff --git a/include/linux/dax.h b/include/linux/dax.h index 87ae4c9b1d65b..3bd1fdb5d5f4b 100644 --- a/include/linux/dax.h +++ b/include/linux/dax.h@@ -48,16 +48,8 @@ void put_dax(struct dax_device *dax_dev); void kill_dax(struct dax_device *dax_dev); void dax_write_cache(struct dax_device *dax_dev, bool wc); bool dax_write_cache_enabled(struct dax_device *dax_dev); -bool __dax_synchronous(struct dax_device *dax_dev); -static inline bool dax_synchronous(struct dax_device *dax_dev) -{ - return __dax_synchronous(dax_dev); -} -void __set_dax_synchronous(struct dax_device *dax_dev); -static inline void set_dax_synchronous(struct dax_device *dax_dev) -{ - __set_dax_synchronous(dax_dev); -} +bool dax_synchronous(struct dax_device *dax_dev); +void set_dax_synchronous(struct dax_device *dax_dev); /* * Check if given mapping is supported by the file / underlying device. */ --2.30.2