Thread (7 messages) 7 messages, 6 authors, 2021-08-07

Re: [PATCH v2] memblock: make memblock_find_in_range method private

From: Kirill A. Shutemov <hidden>
Date: 2021-08-02 08:26:29
Also in: kvmarm, linux-acpi, linux-arm-kernel, linux-devicetree, linux-mips, linux-mm, linux-riscv, lkml

On Mon, Aug 02, 2021 at 09:37:37AM +0300, Mike Rapoport wrote:
From: Mike Rapoport <redacted>

There are a lot of uses of memblock_find_in_range() along with
memblock_reserve() from the times memblock allocation APIs did not exist.

memblock_find_in_range() is the very core of memblock allocations, so any
future changes to its internal behaviour would mandate updates of all the
users outside memblock.

Replace the calls to memblock_find_in_range() with an equivalent calls to
memblock_phys_alloc() and memblock_phys_alloc_range() and make
memblock_find_in_range() private method of memblock.

This simplifies the callers, ensures that (unlikely) errors in
memblock_reserve() are handled and improves maintainability of
memblock_find_in_range().

Signed-off-by: Mike Rapoport <redacted>
Looks good to me:

Acked-by: Kirill A. Shutemov <redacted>

-- 
 Kirill A. Shutemov
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help